Skip to main content

Verify SSL Certificates for Requests.

pixee:python/requests-verify

ImportanceReview GuidanceRequires Scanning Tool
HighMerge After Cursory ReviewNo

This codemod checks that calls to the requests module API or the httpx library use verify=True or a path to a CA bundle to ensure TLS certificate validation.

The requests documentation warns that the verify flag

When set to False, requests will accept any TLS certificate presented by the server, and will ignore hostname mismatches and/or expired certificates, which will make your application vulnerable to man-in-the-middle (MitM) attacks. Setting verify to False may be useful during local development or testing.

Similarly, setting verify=False when using the httpx library to make requests disables certificate verification.

The changes from this codemod look like this:

  import requests

- requests.get("www.google.com", ...,verify=False)
+ requests.get("www.google.com", ...,verify=True)
...
import httpx

- httpx.get("www.google.com", ...,verify=False)
+ httpx.get("www.google.com", ...,verify=True)

This codemod also checks other methods in the requests module and httpx library that accept a verify flag (e.g. requests.post, httpx.AsyncClient, etc.)

If you have feedback on this codemod, please let us know!

F.A.Q.

Why is this codemod marked as Merge After Cursory Review?

There may be times when setting verify=False is useful for testing though we discourage it. You may also decide to set verify=/path/to/ca/bundle. This codemod will not attempt to modify the verify value if you do set it to a path.

Codemod Settings

N/A

References