Added missing synchronized keyword (Sonar)
sonar:java/overrides-match-synchronization-s3551​
| Importance | Review Guidance | Requires Scanning Tool |
|---|---|---|
| MEDIUM | Merge After Cursory Review | Yes (Sonar) |
This change adds missing synchronized keyword to methods that override a synchronized method in the parent class. Our changes look something like this:
interface AcmeParent {
synchronized void doThing();
}
class AcmeChild implements AcmeParent {
@Override
- void doThing() {
+ synchronized void doThing() {
thing();
}
}
F.A.Q.​
Are there other ways to implement this?​
There are a number of different ways to fix this, but essentially we need to make this code thread-safe. This is important when the parent interface implies something is synchronized, signaling an expectation of thread-safety, when an implementation is not.