Prevent database resource leaks (CodeQL)
codeql:java/database-resource-leak​
| Importance | Review Guidance | Requires Scanning Tool |
|---|---|---|
| MEDIUM | Merge Without Review | Yes (CodeQL) |
This change adds try-with-resources to JDBC code to prevent database resources from being leaked, which could lead to denial-of-service conditions like connection pool or file handle exhaustion.
Our changes look something like this:
- Statement stmt = conn.createStatement();
- ResultSet rs = stmt.executeQuery(query);
- // do stuff with results
+ try (Statement stmt = conn.createStatement()) {
+ ResultSet rs = stmt.executeQuery(query);
+ // do stuff with results
+ }
F.A.Q.​
Why is this codemod marked as Merge Without Review?​
This codemod causes database resources to be cleaned up immediately after use instead of at garbage collection time, and we don't believe this change entails any risk.